Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cycleway:lane:SIDE where cycleway:SIDE is present #1209

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add cycleway:lane:SIDE where cycleway:SIDE is present #1209

wants to merge 1 commit into from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Apr 29, 2024 •
edited
Loading

Test out support for https://wiki.openstreetmap.org/wiki/Key:cycleway:lane.

This is part of #1164.

This is a draft for now to experiment via Preview with different ways to model this in the existing schema.

We might want to use a directionalCombo for this. However, that would suggest to tag data for cycleway:left:lane=* when in fact there is no cycleway:left=lane. This tries to work around this by adding separate fields with re-conditions.

Another solution for this would be ideditor/schema-builder#153.

@tordans
Test cycleway_lane tagging with separate fields
3948e35 
We might want to use a directionalCombo for this. However, that would suggest to tag data for cycleway:left:lane=* when in fact there is no cycleway:left=lane. This tries to work around this by adding separate fields with re-conditions.
This was referenced Apr 29, 2024
Open
Open
@github-actions GitHub Actions
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator Author

tordans commented Apr 29, 2024 •
edited
Loading

Testing

"cycleway:right:lane"="advisory"

"cycleway:both:lane"="advisory"

Left/right different

More fields

  • Fields are not present here; probably due to the allowedTags condition
  • image

More fields shows up

It does show up if the conditions match.

@tordans
Copy link
Collaborator Author

tordans commented Apr 29, 2024

Next steps

  • Solve the cyclway:both=* and cycleway=* issue in the prerequisiteTag; do we need to add another field for this?
  • Probably add a readme to the folder that explains the weird setup.
  • Move from moreFields to fields so users are nudged to add the data
  • Add "undefined" option to dropdown
  • Double check highway presets (any missing?)
  • Extract into @template from highway presets
  • Update wording "Left Bike Lane Type" (because "Bike Lanes" is the directionalCombo)

@tordans tordans changed the title Test cycleway_lane tagging with separate fields Add cycleway:lane:SIDE where cycleway:SIDE is present May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tordans